AGS 3.6.0 - Release Candidate (RC 11)

Started by Crimson Wizard, Fri 07/10/2022 00:21:56

Previous topic - Next topic

Crimson Wizard

Quote from: Pax Animo on Fri 04/11/2022 00:59:39I'm having issues with the pull down properties menu for rooms/gui's... and so forth. The pull down menu does not show or at least it simply shows a white box.

@Pax Animo, could you check out this temp build and see if it fixes the problem for you?
https://cirrus-ci.com/task/5409147177402368

Pax Animo

Quote from: Crimson Wizard on Wed 23/11/2022 19:16:41@Pax Animo, could you check out this temp build and see if it fixes the problem for you?
https://cirrus-ci.com/task/5409147177402368

This fixes my problem. Cheers
Misunderstood

Crimson Wizard

#22
Updated to RC3 (3.6.0.38)
(use download links in the first post)

Editor:
 - Fixed property grid's combo box not drawn correctly if a color theme is applied.
 - Fixed project tree's folders collapsing when renaming an item in its properties.

Engine:
 - Fixed WaitInput() incorrectly handled "input type" argument.
 - Fixed empty view loops (with no frames) unexpectedly playing a sound clip with id 0 when being switched to.
 - Fixed crash if slider's handle image was set to negative sprite id (this was possible to do in the older editors).

Compatibility:
 - Use the dummy frame if current character's speech view loop does not have any (happens in some old games).

Reported issues remaining:
* GUI controls incorrectly blend (mix colors) with the parent GUI if parent's transparency is anything but 0.
* Direct3D is said to still be not fully stable when alt+tabbing in exclusive fullscreen mode: https://www.adventuregamestudio.co.uk/forums/ags-engine-editor-releases/ags-3-6-0-release-candidate-rc1/msg636650995/#msg636650995



Unfortunately, I was only just now told by Alan Drake, that the GUI controls are drawn incorrectly if their parent GUI has non-zero Transparency. In short, they mix colors with the GUI's colors, as if they were translucent on their own relative to the parent. This is related to the recent change in 3.6.0 that makes these gui controls drawn as separate textures by Direct3D/OpenGL renderers (for perfomance purposes). This is a serious problem, and I will have to suspend the final release until the solution is found and implemented.

Snarky

I made a small project with 3.5.0 yesterday. When I tried upgrading, rebuilding and running it with this RC today, it crashes on launch. (Crash dump)

Crimson Wizard

Quote from: Snarky on Tue 29/11/2022 14:47:58I made a small project with 3.5.0 yesterday. When I tried upgrading, rebuilding and running it with this RC today, it crashes on launch. (Crash dump)

Would it be possible to get a 3.5.0 project itself (or at least one upgraded to 3.6.0, if 3.5.0 is not available)? If the crash is related to an incorrect upgrade, for example, then it will be easier to find out what went wrong.

Snarky

Here you have copies of the project both before and after the version upgrade.

Crimson Wizard

Quote from: Snarky on Tue 29/11/2022 16:30:49Here you have copies of the project both before and after the version upgrade.

Hm, I tried both 3.5.0 and 3.6.0 projects with the 3.6.0 RC3, and see no crash on game launch...

Snarky

Presumably there are some aspects of 3.6 builds that aren't supported on my environment. Did the crash dump tell you anything?

eri0o

It looks like it's failing at SDL_Init (sys_main.cpp line 42), but I don't have the kernelbase.dll file in my windows and I can't find it's symbols, so I don't know what the exception is - I think Snarky is in Windows 7?

Crimson Wizard

Quote from: Snarky on Tue 29/11/2022 19:42:18Presumably there are some aspects of 3.6 builds that aren't supported on my environment. Did the crash dump tell you anything?

Ah, unfortunately I did not download it earlier, and it's not available now.

I am also on Windows 7, by the way.

eri0o

#30
The crash dump is also in the Compiled/Windows dir of the attached project in the previous link!

I find the alternate data stream file there (the TestEdge.exe_Zone.Identifier_$DATA) suspicious, and the exe file URL in it doesn't match the exe file location in the crash dump.  :-\

(the ZoneId being 3 is even more curious, it means the file came from the internet)

Crimson Wizard

So, the crash happens inside SDL2.dll. Afaik we do not have debug symbols for this library? Unless we build it ourselves...

@Snarky, could you try using this SDL2.dll instead and repost the crash dump if crash happens again?
https://www.dropbox.com/s/ionvpr7nfla17zv/SDL2-2.24.1-Debug.zip?dl=1

Snarky

#32
I'm running Windows 10 in VirtualBox to build the project, and running the EXE in Wine, both on MacOS 10.13.6. (AGS games don't run for me in VirtualBox.) I know it's an unusual setup, but I don't have access to a native Windows box, and it works fine when built with 3.5.0.

The VM/Wine environments probably use different remappings of the AGS project folder, which may be why it doesn't match. The path in the exe_Zone.Identifier_$DATA file seems to refer to the download location of the AGS 3.5.0 editor before unzipping and installing. (I have installed it, and honestly don't know how it could even know the directory where the zip file was saved.) The $DATA file comes from building in 3.5.0; in the 3.6.0 project it's just a remnant of building the game before the update.

I'll try with the other SDL2 file. Where do I need to drop it, and do I need to recompile?

eri0o

Just remove the SDL2.dll in the Compiled/Windows directory and add this new one and double click the game exe to trigger the crash again. :)

Snarky

#34
With the replacement SDL2.dll it fails to crash. (laugh)
Thanks @Crimson Wizard! Though I don't suppose that is very helpful to isolate the problem.

Crimson Wizard

Quote from: Snarky on Tue 29/11/2022 22:08:55I'm running Windows 10 in VirtualBox to build the project, and running the EXE in Wine, both on MacOS 10.13.6.

So, to clarify that I understand right, you are launching the game in Wine under Mac?

Snarky


eri0o

Hey @Snarky , if you wish, this specific 3.6.0.38, the MacOS build for release of the engine is here https://cirrus-ci.com/task/5718421195718656 , under binaries/bin_12.3_release, there should be an ags artifact, it should be able to run from the command line.  :)


Snarky

Thanks. It's great to have a MacOS build of the engine, but there are a lot of situations where I prefer Wine, for various reasons:

1. I often need to use Windows-only plugins.
2. I sometimes specifically want to run/test the Windows version.
3. When developing and testing, with frequent recompiles, I find it more straightforward and convenient to launch a ready-made EXE.
4. When a game crashes on MacOS, it doesn't always provide the same reporting that the Windows build does.
5. Some Mac versions of games don't run correctly, in my experience.

Crimson Wizard

Quote from: Snarky on Tue 29/11/2022 23:09:09With the replacement SDL2.dll it fails to crash. (laugh)
Thanks @Crimson Wizard! Though I don't suppose that is very helpful to isolate the problem.

So, I guess we need to
1) find out what's the difference between SDL2.dll that I built and SDL2.dll that is supplied with the AGS.
2) report to SDL2 team, as this is a SDL2 error, not AGS error.

I built from a release-2.24.1 tag from their repository, and built using provided SDL.sln with MSVS 2015.

SMF spam blocked by CleanTalk